History log of /haiku/src/system/kernel/locks/lock.cpp
Revision Date Author Comments
# 8dae411c 04-Aug-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel/locks: Tweak mutex_unlock KDEBUG semantics slightly.

Previously, both the "old" owner and the "new" lock owner set
the lock holder to the "new" lock holder. Now the old owner does
it before calling unblock(), and we check in the lock() functions
that we are indeed the new owner of the lock.

This may affect what the panic is for #15211 and its duplicates:
I have a suspicion that these threads are getting unblocked
when they have no business being unblocked, and this should
catch that condition.


# c2cbf958 02-May-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Add and fix ownership checks in mutex_destroy and mutex_transfer.

* mutex_destroy() only checked wether or not there were waiters,
not if the lock itself was presently held by another thread.
Now we do, which should make #15015 panic much earlier instead
of trying to use freed memory.
* mutex_transfer_lock() and recursive_lock_transfer_lock() did
not check that the calling thread actually owned the lock.
Now it does, which should trigger asserts if anyone tries
to do this.


# 7a15c1cb 06-Apr-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Add interrupts checks for switch_lock functions.


# dd0667da 04-Apr-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel/locks: Don't panic on interrupts disabled in unlock().

We don't reschedule or block in here, so checking for interrupts
is needlessly strict. Sorry for the noise, forgot to remove this
before the previous commit.


# 93cf1243 04-Apr-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Add checks for interrupts in rwlocks.

recursive_locks, mutexes, and semaphores already have them.


# b3225546 15-Mar-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Check for uninitialized locks in mutex_trylock().

We already do this in mutex_lock() and variants.


# c32137f3 08-Mar-2019 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Tweak some mutex functions.

* Remove code duplication.
* Make _mutex_trylock work in non-KDEBUG kernels. This should fix
spurious failures to lock in drivers compiled for KDEBUG kernels
running under non-KDEBUG kernels.


# 8844a67e 10-Dec-2018 Augustin Cavalier <waddlesplash@gmail.com>

More trivial syntax and logic cleanup.

Spotted by Clang. No functional change intended.


# adb4e6e8 28-Oct-2018 Augustin Cavalier <waddlesplash@gmail.com>

kernel: Reset lock holder and count on mutex_destroy().

Previously, there were a number of circumstances where these were
not getting reset properly, leading to some destroyed mutexes having
holders of the last thread which locked them, and some with "-1",
which meant that the next call to "mutex_lock" just behaved as if
the lock was still valid (!), and so the unlucky caller would deadlock
forever.

Now we properly reset these fields, which means from now on attempts to
lock or unlock destroyed mutexes will lead to "PANIC: uninitialized mutex"
on KDEBUG kernels, and (as before) an infinite deadlock on non-KDEBUG
kernels (perhaps we should store the thread_id of the locker on non-KDEBUG
kernels also?).

As the next commits will show, this already uncovered a number of bugs,
and there are of course potentially more strange deadlocks caused by this.


# ffba6606 29-Mar-2015 Michael Lotz <mmlr@mlotz.ch>

UserlandFS: Make 64 bit clean and enable build for x86_64.

I did not bother to fix the BeOS kernel emulation, so this part is
still left out of the x86_64 build.


# 1ee1d0cb 28-Nov-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel, drivers: Fix gcc2 build


# 3eb4224b 20-Nov-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Make sure mutex::holder is set to a valid value


# c8dd9f77 29-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Add thread_unblock() and use it where possible


# d70728f5 29-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel/lock: Do not use *_locked() functions when not needed


# 31a75d40 23-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Protect lock internals with per-lock spinlock


# b7b5d763 17-Dec-2012 Sergei Reznikov <diver@gelios.net>

64-bit fixes for kernel with KDEBUG_LEVEL = 0

Signed-off-by: Alex Smith <alex@alex-smith.me.uk>


# 4be4fc6b 15-Jun-2012 Alex Smith <alex@alex-smith.me.uk>

More 64-bit compilation/safety fixes.


# 24df6592 11-Jun-2011 Ingo Weinhold <ingo_weinhold@gmx.de>

Merged signals-merge branch into trunk with the following changes:
* Reorganized the kernel locking related to threads and teams.
* We now discriminate correctly between process and thread signals. Signal
handlers have been moved to teams. Fixes #5679.
* Implemented real-time signal support, including signal queuing, SA_SIGINFO
support, sigqueue(), sigwaitinfo(), sigtimedwait(), waitid(), and the addition
of the real-time signal range. Closes #1935 and #2695.
* Gave SIGBUS a separate signal number. Fixes #6704.
* Implemented <time.h> clock and timer support, and fixed/completed alarm() and
[set]itimer(). Closes #5682.
* Implemented support for thread cancellation. Closes #5686.
* Moved send_signal() from <signal.h> to <OS.h>. Fixes #7554.
* Lots over smaller more or less related changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42116 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4535495d 10-Jan-2011 Ingo Weinhold <ingo_weinhold@gmx.de>

Merged the signals branch into trunk, with these changes:
* The team and thread kernel structures have been renamed to Team and Thread
respectively and moved into the new BKernel namespace.
* Several (kernel add-on) sources have been converted from C to C++ since
private kernel headers are included that are no longer C compatible.

Changes after merging:
* Fixed gcc 2 build (warnings mainly in the scary firewire bus manager).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40196 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4e08fb85 22-Jul-2010 Ingo Weinhold <ingo_weinhold@gmx.de>

Added rw_lock_read_lock_with_timeout().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37680 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 813d4cbe 11-Apr-2010 Ingo Weinhold <ingo_weinhold@gmx.de>

* Moved created subdirectory src/system/kernel/lock.cpp to new subdirectory
locks.
* Added syscalls for a new kind of mutex. A mutex consists only of an int32 and
doesn't require any kernel resources. So it's initialization cannot fail
(it consists only of setting the mutex value to 0). An uncontended lock or
unlock operation can basically consist of an atomic_*() in userland. The
syscalls (when the mutex is contended) are a bit more expensive than semaphore
operations, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36158 a95241bf-73f2-0310-859d-f6bbb57e9c96


# ffba66060b0155c987fc2232b803b243610c6430 29-Mar-2015 Michael Lotz <mmlr@mlotz.ch>

UserlandFS: Make 64 bit clean and enable build for x86_64.

I did not bother to fix the BeOS kernel emulation, so this part is
still left out of the x86_64 build.


# 1ee1d0cbab735cd0849fefaa1ee62ae8fe83d7a5 28-Nov-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel, drivers: Fix gcc2 build


# 3eb4224bf6d658b0e95412d348e6656fefe92f65 20-Nov-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Make sure mutex::holder is set to a valid value


# c8dd9f7780c426e592a3ccb231e6bfab51f15eb9 29-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Add thread_unblock() and use it where possible


# d70728f54da5b22311b6f271a60fe2067ae4a47b 29-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel/lock: Do not use *_locked() functions when not needed


# 31a75d402f761a1087c449e44926a6bec0c31009 23-Oct-2013 Pawel Dziepak <pdziepak@quarnos.org>

kernel: Protect lock internals with per-lock spinlock


# b7b5d7636b96de53bb4327684cc1843e56f62320 17-Dec-2012 Sergei Reznikov <diver@gelios.net>

64-bit fixes for kernel with KDEBUG_LEVEL = 0

Signed-off-by: Alex Smith <alex@alex-smith.me.uk>


# 4be4fc6b1faddbd037146214a0011d320842b4f3 15-Jun-2012 Alex Smith <alex@alex-smith.me.uk>

More 64-bit compilation/safety fixes.


# 24df65921befcd0ad0c5c7866118f922da61cb96 11-Jun-2011 Ingo Weinhold <ingo_weinhold@gmx.de>

Merged signals-merge branch into trunk with the following changes:
* Reorganized the kernel locking related to threads and teams.
* We now discriminate correctly between process and thread signals. Signal
handlers have been moved to teams. Fixes #5679.
* Implemented real-time signal support, including signal queuing, SA_SIGINFO
support, sigqueue(), sigwaitinfo(), sigtimedwait(), waitid(), and the addition
of the real-time signal range. Closes #1935 and #2695.
* Gave SIGBUS a separate signal number. Fixes #6704.
* Implemented <time.h> clock and timer support, and fixed/completed alarm() and
[set]itimer(). Closes #5682.
* Implemented support for thread cancellation. Closes #5686.
* Moved send_signal() from <signal.h> to <OS.h>. Fixes #7554.
* Lots over smaller more or less related changes.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42116 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4535495d80c86e19e2610e7444a4fcefe3e0f8e6 10-Jan-2011 Ingo Weinhold <ingo_weinhold@gmx.de>

Merged the signals branch into trunk, with these changes:
* The team and thread kernel structures have been renamed to Team and Thread
respectively and moved into the new BKernel namespace.
* Several (kernel add-on) sources have been converted from C to C++ since
private kernel headers are included that are no longer C compatible.

Changes after merging:
* Fixed gcc 2 build (warnings mainly in the scary firewire bus manager).


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40196 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 4e08fb85894083c9e677a17405834bbb4d41d575 22-Jul-2010 Ingo Weinhold <ingo_weinhold@gmx.de>

Added rw_lock_read_lock_with_timeout().


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37680 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 813d4cbe94b99e33ac2b921ae76df4d1b2b39b40 11-Apr-2010 Ingo Weinhold <ingo_weinhold@gmx.de>

* Moved created subdirectory src/system/kernel/lock.cpp to new subdirectory
locks.
* Added syscalls for a new kind of mutex. A mutex consists only of an int32 and
doesn't require any kernel resources. So it's initialization cannot fail
(it consists only of setting the mutex value to 0). An uncontended lock or
unlock operation can basically consist of an atomic_*() in userland. The
syscalls (when the mutex is contended) are a bit more expensive than semaphore
operations, though.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36158 a95241bf-73f2-0310-859d-f6bbb57e9c96