History log of /haiku/src/preferences/shortcuts/ShortcutsWindow.cpp
Revision Date Author Comments
# a5167229 14-Jul-2018 Janus <janus2@ymail.com>

Shortcuts: save columns information

- Clean up useless code
- Remove horizontal scrollbar
- Fixes #14278

Change-Id: I7edcb998bfca4b90d02f949b6e7979bcdbcc3cbb


# 8d6561d6 14-Jul-2018 Janus <janus2@ymail.com>

Shortcuts: Use ALT-R for "Revert to saved"

- Fixes #14275

Change-Id: I2ca692e277c130fcee5edd202976ab748d811d7b


# eff2d235 10-Jul-2016 Humdinger <humdingerb@gmail.com>

Make Shortcuts prefs window resizable

Use layoutmanagement aware c'tors and SetExplicitMaxSize().
Fixes #12849.


# d0ac6099 07-Nov-2015 Humdinger <humdingerb@gmail.com>

Use B_USE_WINDOW_SPACING

Use B_USE_WINDOW_SPACING as inset from contents to window border.
Some whitespace cleanup.


# d2297737 23-Jan-2015 Rene Gollent <rene@gollent.com>

Shortcuts: Automatic whitespace cleanup.


# d13b9014 23-Jan-2015 Rene Gollent <rene@gollent.com>

Shortcuts: Fix #11777.

- Add missing B_AUTO_UPDATE_SIZE_LIMITS flag to window, otherwise it
never recomputes its initial size in the absence of previously
stored settings.


# 149ce46d 09-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Update Shortcuts to use standard ColumnListView

Patch by atalax (GCI2014)

There are some useability changes because our CLV isn't as flexible as
the Santa's Gift Bag one.

Fixes #11007.


# b42302c5 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 0bbc331f 10-May-2013 Jérôme Duval <jerome.duval@gmail.com>

ShorcutsPreferences: fixes 64 bit warnings


# 776c58b2 30-Dec-2012 Humdinger <humdingerb@gmail.com>

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.


# aed35104 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 546208a5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# ce59b51c 02-Jul-2011 Rene Gollent <anevilyak@gmail.com>

Applied patch by Brian Luft to clean up the shortcuts GUI and bring it more
into HIG compliance. Resolves part of #5420. Thanks!



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42363 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 62769fc6 26-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 560ff447 25-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96


# d374a272 16-Mar-2011 Jonas Sundström <jonas@kirilla.com>

App name localization.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40980 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 3672a07e 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 9c1a9b92 20-Dec-2009 Adrien Destugues <pulkomandy@pulkomandy.ath.cx>

* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c333678 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96


# d2297737364abef41c0735a53a0a19bf205940c0 23-Jan-2015 Rene Gollent <rene@gollent.com>

Shortcuts: Automatic whitespace cleanup.


# d13b9014e8274cb0f1ea9968562de885743c431c 23-Jan-2015 Rene Gollent <rene@gollent.com>

Shortcuts: Fix #11777.

- Add missing B_AUTO_UPDATE_SIZE_LIMITS flag to window, otherwise it
never recomputes its initial size in the absence of previously
stored settings.


# 149ce46d14fb60917b78e8f02343112f0ba96978 09-Jan-2015 Adrien Destugues <pulkomandy@gmail.com>

Update Shortcuts to use standard ColumnListView

Patch by atalax (GCI2014)

There are some useability changes because our CLV isn't as flexible as
the Santa's Gift Bag one.

Fixes #11007.


# b42302c5d343ffce4d7ed87bed26e7ffcabce1ae 20-Jan-2014 John Scipione <jscipione@gmail.com>

Shortcuts: Big style refactor

Update the style of this preference app to match Haiku’s coding guidelines.
Since this app used a completely different style this is a big commit, but,
there should be no behavioral changes.

Style changes include but are not limited to:
* private member variables use fMemberVariable style
* local variables and public member variables use camelCase style
* compare pointers to NULL explicitly
* compare integers against 0 explicitly
* always flank binary operators with spaces such as + - , / *
* pointer goes with type, not value or flanked by spaces
* lots of variable renaming especially for abbreviations
* comments start with a leading space, prefer lowercase unless full sentence
* space after keywords such as if and for and { and } on same line
* multi-line if statement style fixes
* remove trailing spaces
* 80 char fixes
* ... and many more, and I'm sure I missed some.

Add/update copyright headers giving credit where due, obviously this code
can’t be copyright Haiku, Inc. from 1999 since Haiku, Inc. didn’t exist
so this change attributes copyright to Jeremy Friesner from 1999-2009 and
Haiku, Inc. from 2009 onwards matching the long description of the rdef file.

Added myself to the authors section of the files in the clv directory.


# 0bbc331f6b5a56c98243fcf9c1f2dadff4450b9f 10-May-2013 Jérôme Duval <jerome.duval@gmail.com>

ShorcutsPreferences: fixes 64 bit warnings


# 776c58b2b56d8bcf33638a2ecb6c697f95a1cbf3 30-Dec-2012 Humdinger <humdingerb@gmail.com>

Unifying the quit/save alerts.

Wherever I found an alert prompting to save changes, I used the
button labeling 'Cancel', 'Don't save', 'Save' with the first button
left aligned, 2nd and 3rd right aligned.

I added the shortcuts 'd' for 'Don't save, and 's' for 'Save' where
not already set.

The topic was discussed at
http://permalink.gmane.org/gmane.os.haiku.devel/23244
The discussion died down, I hope I made changes everyone can live with.


# aed35104852941f0f6f3d1dcc5338b5f337d0a3c 05-Aug-2012 Humdinger <humdingerb@gmail.com>

Close alerts with ESCAPE key.

Added SetFlags(B_CLOSE_ON_ESCAPE) or SetShortcut(index, B_ESCAPE) to BAlerts
depending if the result gets used later in the code, or if it's a one-button
BAlert.


# 546208a53940a26c6379c48a7854ade1a8250fc5 16-Apr-2012 Oliver Tappe <zooey@hirschkaefer.de>

More catalog-related cleanup.

* rename B_TRANSLATE_CONTEXT to B_TRANSLATION_CONTEXT and
B_TRANSLATE_WITH_CONTEXT to B_TRANSLATE_CONTEXT, squashing a TODO
* adjust all uses of both macros in Haiku's source tree
* use correct header guard for collecting/Catalog.h

The renamed macros require adjustments to all external applications
using catalogs.


# ce59b51ce35154b2c06759bfb1a43beffc68a100 02-Jul-2011 Rene Gollent <anevilyak@gmail.com>

Applied patch by Brian Luft to clean up the shortcuts GUI and bring it more
into HIG compliance. Resolves part of #5420. Thanks!



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42363 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 62769fc6d5b7ee60cea4d6e289316a5e20e0c5d4 26-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Follow-up on r41108. Removal of About-windows and menu items.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41115 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 560ff4478d5c85455ea3e5ed5e392ef93132d545 25-Mar-2011 Jonas Sundström <jonas@kirilla.com>

Use resource definition files instead of DoCatalogs rule. Rename B_TRANSLATE_APP_NAME and related macros to the more generic B_TRANSLATE_SYSTEM_NAME, to also fits add-ons, folders, etc, and make 'System name' its standard context. Change CodyCam and PoorMan's app signatures to match the overall x-vnd.Haiku-App pattern. Some clean-up. Make SlideShowSaver build again.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@41103 a95241bf-73f2-0310-859d-f6bbb57e9c96


# d374a27286b8a52974a97dba0d5966ea026a665d 16-Mar-2011 Jonas Sundström <jonas@kirilla.com>

App name localization.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@40980 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 3672a07ec16784e41fe56eeaa558095bc2befc02 16-May-2010 Stephan Aßmus <superstippi@gmx.de>

Localization of Shortcuts based on a patch by Jorma Karvonen (ticket #5857),
thanks! I've tested the application, and it works (as bad) as before. To note
would be the possibility that custom actions may stop working when switching
the system to another language after configuring them. Don't know if I
concluded this potential problem from the code correctly, or if translated
strings are actually not stored with a KeySet.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@36840 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 9c1a9b926aa0b1890a011a44398379d1c47f09c1 20-Dec-2009 Adrien Destugues <pulkomandy@pulkomandy.ath.cx>

* Patch by Humdinger to convert a lot of things to sentance case.
* Cleanup and update of all the touched catkeys files


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34731 a95241bf-73f2-0310-859d-f6bbb57e9c96


# fa1ee6d4d1c15a655d7d5877f88f7e397be16bb7 15-Nov-2009 Jonas Sundström <jonas@kirilla.com>

Clean-up

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@34059 a95241bf-73f2-0310-859d-f6bbb57e9c96


# 6c3336782537a5618a4234cfb56e3b17dfee0f72 30-Oct-2009 Fredrik Modeen <fredrik@modeen.se>

So here it goes..
I hope I have fixed all parts that don't follow our guidelines. (that python script was good start)
This are the app, I havn't change the file in clv those are from Santa gift bag

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@33848 a95241bf-73f2-0310-859d-f6bbb57e9c96